@Before public void setUp() throws Exception { cleanupTaskPreferences(); taskPreference = mock(TaskPreference.class); PluggableTaskConfigStore.store().setPreferenceFor("plugin-1", taskPreference); TaskView view = mock(TaskView.class); when(taskPreference.getView()).thenReturn(view); when(view.template()).thenReturn("<input type='text' ng-model='abc'></input>"); when(view.displayValue()).thenReturn("First plugin"); }
private void loadTaskConfigIntoPreferenceStore(GoPluginDescriptor descriptor) { if (taskExtension.canHandlePlugin(descriptor.id())) { taskExtension.doOnTask(descriptor.id(), (task, pluginDescriptor) -> PluggableTaskConfigStore.store().setPreferenceFor(pluginDescriptor.id(), new TaskPreference(task))); } }
@Test public void isValidShouldVerifyForValidConfigurationProperties() { PluginConfiguration pluginConfiguration = new PluginConfiguration("github.pr", "1.1"); Configuration configuration = mock(Configuration.class); PluggableTaskConfigStore.store().setPreferenceFor(pluginConfiguration.getId(), mock(TaskPreference.class)); when(configuration.hasErrors()).thenReturn(true); PluggableTask pluggableTask = new PluggableTask(pluginConfiguration, configuration); assertFalse(pluggableTask.isValid()); verify(configuration).validateTree(); verify(configuration).hasErrors(); }
@Test public void shouldRegisterViewEngineForPluggableTask() { TaskPreference taskPreference = mock(TaskPreference.class); TaskView view = mock(TaskView.class); when(taskPreference.getView()).thenReturn(view); when(view.template()).thenReturn("plugin-template-value"); when(view.displayValue()).thenReturn("Plugin display value"); PluggableTaskConfigStore.store().setPreferenceFor("plugin1", taskPreference); PluggableTask pluggableTask = new PluggableTask(new PluginConfiguration("plugin1", "2"), new Configuration()); PluggableViewModel<PluggableTask> pluggableTaskViewModel = registry.getViewModelFor(pluggableTask, "new"); assertEquals(PluggableTaskViewModel.class, pluggableTaskViewModel.getClass()); assertThat(pluggableTaskViewModel.getModel(), is(pluggableTask)); }
@Test public void shouldRemoveConfigForTheTaskCorrespondingToGivenPluginId() throws Exception { final GoPluginDescriptor descriptor = mock(GoPluginDescriptor.class); String pluginId = "test-plugin-id"; when(descriptor.id()).thenReturn(pluginId); final Task task = mock(Task.class); TaskConfig config = new TaskConfig(); TaskView taskView = mock(TaskView.class); when(task.config()).thenReturn(config); when(task.view()).thenReturn(taskView); PluggableTaskConfigStore.store().setPreferenceFor(pluginId, new TaskPreference(task)); PluginManager pluginManager = mock(PluginManager.class); PluggableTaskPreferenceLoader pluggableTaskPreferenceLoader = new PluggableTaskPreferenceLoader(pluginManager, taskExtension); assertThat(PluggableTaskConfigStore.store().hasPreferenceFor(pluginId), is(true)); pluggableTaskPreferenceLoader.pluginUnLoaded(descriptor); assertThat(PluggableTaskConfigStore.store().hasPreferenceFor(pluginId), is(false)); verify(pluginManager).addPluginChangeListener(pluggableTaskPreferenceLoader); }
@Test public void shouldGetOnlyConfiguredPropertiesIfACertainPropertyDefinedByPluginIsNotConfiguredByUser() throws Exception { Task taskDetails = mock(Task.class); TaskConfig taskConfig = new TaskConfig(); addProperty(taskConfig, "KEY2", "Key 2", 1); addProperty(taskConfig, "KEY1", "Key 1", 0); addProperty(taskConfig, "KEY3", "Key 3", 2); when(taskDetails.config()).thenReturn(taskConfig); when(taskDetails.view()).thenReturn(mock(TaskView.class)); String pluginId = "plugin_with_all_details"; PluggableTaskConfigStore.store().setPreferenceFor(pluginId, new TaskPreference(taskDetails)); Configuration configuration = new Configuration( ConfigurationPropertyMother.create("KEY1", false, "value1"), ConfigurationPropertyMother.create("KEY2", false, "value2") ); PluggableTask task = new PluggableTask(new PluginConfiguration(pluginId, "1"), configuration); List<TaskProperty> propertiesForDisplay = task.getPropertiesForDisplay(); assertThat(propertiesForDisplay.size(), is(2)); assertProperty(propertiesForDisplay.get(0), "Key 1", "value1", "key1"); assertProperty(propertiesForDisplay.get(1), "Key 2", "value2", "key2"); }
@Test public void shouldNotOverwriteValuesIfTheyAreNotAvailableInConfigAttributesMap() throws Exception { TaskPreference taskPreference = mock(TaskPreference.class); Configuration configuration = new Configuration(ConfigurationPropertyMother.create("KEY1"), ConfigurationPropertyMother.create("Key2")); PluggableTaskConfigStore.store().setPreferenceFor("abc.def", taskPreference); PluggableTask task = new PluggableTask(new PluginConfiguration("abc.def", "1"), configuration); Map<String, String> attributeMap = DataStructureUtils.m("KEY1", "value1"); TaskConfig taskConfig = new TaskConfig(); TaskProperty property1 = new TaskProperty("KEY1", "value1"); TaskProperty property2 = new TaskProperty("Key2", null); taskConfig.addProperty(property1.getName()); taskConfig.addProperty(property2.getName()); when(taskPreference.getConfig()).thenReturn(taskConfig); task.setTaskConfigAttributes(attributeMap); assertThat(task.configAsMap().get("KEY1").get(PluggableTask.VALUE_KEY), is("value1")); assertThat(task.configAsMap().get("Key2").get(PluggableTask.VALUE_KEY), is(nullValue())); }
@Test public void shouldIgnoreKeysPresentInConfigAttributesMapButNotPresentInConfigStore() throws Exception { TaskPreference taskPreference = mock(TaskPreference.class); Configuration configuration = new Configuration(ConfigurationPropertyMother.create("KEY1")); PluggableTaskConfigStore.store().setPreferenceFor("abc.def", taskPreference); PluggableTask task = new PluggableTask(new PluginConfiguration("abc.def", "1"), configuration); Map<String, String> attributeMap = DataStructureUtils.m("KEY1", "value1", "Key2", "value2"); TaskConfig taskConfig = new TaskConfig(); TaskProperty property1 = new TaskProperty("KEY1", "value1"); taskConfig.addProperty(property1.getName()); when(taskPreference.getConfig()).thenReturn(taskConfig); task.setTaskConfigAttributes(attributeMap); assertThat(task.configAsMap().get("KEY1").get(PluggableTask.VALUE_KEY), is("value1")); assertFalse(task.configAsMap().containsKey("Key2")); }
@Test public void shouldAddPropertyComingFromAttributesMapIfPresentInConfigStoreEvenIfItISNotPresentInCurrentConfiguration() throws Exception { TaskPreference taskPreference = mock(TaskPreference.class); Configuration configuration = new Configuration(ConfigurationPropertyMother.create("KEY1")); PluggableTaskConfigStore.store().setPreferenceFor("abc.def", taskPreference); PluggableTask task = new PluggableTask(new PluginConfiguration("abc.def", "1"), configuration); Map<String, String> attributeMap = DataStructureUtils.m("KEY1", "value1", "Key2", "value2"); TaskConfig taskConfig = new TaskConfig(); TaskProperty property1 = new TaskProperty("KEY1", "value1"); TaskProperty property2 = new TaskProperty("Key2", "value2"); taskConfig.addProperty(property1.getName()); taskConfig.addProperty(property2.getName()); when(taskPreference.getConfig()).thenReturn(taskConfig); task.setTaskConfigAttributes(attributeMap); assertThat(task.configAsMap().get("KEY1").get(PluggableTask.VALUE_KEY), is("value1")); assertThat(task.configAsMap().get("Key2").get(PluggableTask.VALUE_KEY), is("value2")); }
@Test public void shouldPopulatePropertiesForDisplayRetainingOrderAndDisplayNameIfConfigured() throws Exception { Task taskDetails = mock(Task.class); TaskConfig taskConfig = new TaskConfig(); addProperty(taskConfig, "KEY2", "Key 2", 1); addProperty(taskConfig, "KEY1", "Key 1", 0); addProperty(taskConfig, "KEY3", "Key 3", 2); when(taskDetails.config()).thenReturn(taskConfig); when(taskDetails.view()).thenReturn(mock(TaskView.class)); String pluginId = "plugin_with_all_details"; PluggableTaskConfigStore.store().setPreferenceFor(pluginId, new TaskPreference(taskDetails)); Configuration configuration = new Configuration( ConfigurationPropertyMother.create("KEY3", true, "encryptedValue1"), ConfigurationPropertyMother.create("KEY1", false, "value1"), ConfigurationPropertyMother.create("KEY2", false, "value2") ); PluggableTask task = new PluggableTask(new PluginConfiguration(pluginId, "1"), configuration); List<TaskProperty> propertiesForDisplay = task.getPropertiesForDisplay(); assertThat(propertiesForDisplay.size(), is(3)); assertProperty(propertiesForDisplay.get(0), "Key 1", "value1", "key1"); assertProperty(propertiesForDisplay.get(1), "Key 2", "value2", "key2"); assertProperty(propertiesForDisplay.get(2), "Key 3", "****", "key3"); }
@Test public void shouldAddConfigurationProperties() { List<ConfigurationProperty> configurationProperties = Arrays.asList(ConfigurationPropertyMother.create("key", "value", "encValue"), new ConfigurationProperty()); PluginConfiguration pluginConfiguration = new PluginConfiguration("github.pr", "1.1"); TaskPreference taskPreference = mock(TaskPreference.class); TaskConfig taskConfig = new TaskConfig(); Configuration configuration = new Configuration(); Property property = new Property("key"); property.with(Property.SECURE, false); PluggableTaskConfigStore.store().setPreferenceFor(pluginConfiguration.getId(), taskPreference); TaskConfigProperty taskConfigProperty = taskConfig.addProperty("key"); when(taskPreference.getConfig()).thenReturn(taskConfig); PluggableTask pluggableTask = new PluggableTask(pluginConfiguration, configuration); pluggableTask.addConfigurations(configurationProperties); assertThat(configuration.size(), is(2)); }
@Test public void shouldPopulateItselfFromConfigAttributesMap() throws Exception { TaskPreference taskPreference = mock(TaskPreference.class); Configuration configuration = new Configuration(ConfigurationPropertyMother.create("KEY1"), ConfigurationPropertyMother.create("Key2")); PluggableTaskConfigStore.store().setPreferenceFor("abc.def", taskPreference); PluggableTask task = new PluggableTask(new PluginConfiguration("abc.def", "1"), configuration); Map<String, String> attributeMap = DataStructureUtils.m("KEY1", "value1", "Key2", "value2"); TaskConfig taskConfig = new TaskConfig(); TaskProperty property1 = new TaskProperty("KEY1", "value1"); TaskProperty property2 = new TaskProperty("Key2", "value2"); taskConfig.addProperty(property1.getName()); taskConfig.addProperty(property2.getName()); when(taskPreference.getConfig()).thenReturn(taskConfig); task.setTaskConfigAttributes(attributeMap); assertThat(task.configAsMap().get("KEY1").get(PluggableTask.VALUE_KEY), is("value1")); assertThat(task.configAsMap().get("Key2").get(PluggableTask.VALUE_KEY), is("value2")); }
@Test public void postConstructShouldDoNothingForAInvalidConfigurationProperty() throws Exception { TaskPreference taskPreference = mock(TaskPreference.class); ConfigurationProperty configurationProperty = ConfigurationPropertyMother.create("KEY1"); Configuration configuration = new Configuration(configurationProperty); PluggableTaskConfigStore.store().setPreferenceFor("abc.def", taskPreference); TaskConfig taskConfig = new TaskConfig(); when(taskPreference.getConfig()).thenReturn(taskConfig); PluggableTask task = new PluggableTask(new PluginConfiguration("abc.def", "1"), configuration); assertFalse(configurationProperty.isSecure()); task.applyPluginMetadata(); assertFalse(configurationProperty.isSecure()); }
@Test public void postConstructShouldHandleSecureConfigurationForConfigurationProperties() throws Exception { TaskPreference taskPreference = mock(TaskPreference.class); ConfigurationProperty configurationProperty = ConfigurationPropertyMother.create("KEY1"); Configuration configuration = new Configuration(configurationProperty); PluggableTaskConfigStore.store().setPreferenceFor("abc.def", taskPreference); TaskConfig taskConfig = new TaskConfig(); taskConfig.addProperty("KEY1").with(Property.SECURE, true); when(taskPreference.getConfig()).thenReturn(taskConfig); PluggableTask task = new PluggableTask(new PluginConfiguration("abc.def", "1"), configuration); assertFalse(configurationProperty.isSecure()); task.applyPluginMetadata(); assertTrue(configurationProperty.isSecure()); }
@Test public void shouldHandleSecureConfigurations() throws Exception { TaskPreference taskPreference = mock(TaskPreference.class); Configuration configuration = new Configuration(); PluggableTaskConfigStore.store().setPreferenceFor("abc.def", taskPreference); PluggableTask task = new PluggableTask(new PluginConfiguration("abc.def", "1"), configuration); Map<String, String> attributeMap = DataStructureUtils.m("KEY1", "value1"); TaskConfig taskConfig = new TaskConfig(); taskConfig.addProperty("KEY1").with(Property.SECURE, true); when(taskPreference.getConfig()).thenReturn(taskConfig); task.setTaskConfigAttributes(attributeMap); assertThat(task.getConfiguration().size(), is(1)); assertTrue(task.getConfiguration().first().isSecure()); assertThat(task.getConfiguration().first().getValue(), is("value1")); }
PluggableTaskConfigStore.store().setPreferenceFor("plugin-id-1", new TaskPreference(new com.thoughtworks.go.plugin.api.task.Task() { @Override public TaskConfig config() {