@Override public boolean hasErrors() { return super.hasErrors() || !configErrors.isEmpty(); }
public boolean hasErrors() { return !errors.isEmpty() || configuration.hasErrors(); }
@Override public boolean hasErrors() { return super.hasErrors() || !errors().isEmpty(); }
@Override public boolean validateTree(ValidationContext validationContext) { validate(validationContext); return (onCancelConfig.validateTree(validationContext) && errors.isEmpty() && !configuration.hasErrors()); }
public boolean isValid() { if (PluggableTaskConfigStore.store().preferenceFor(pluginConfiguration.getId()) == null) { addError(TYPE, String.format("Could not find plugin for given pluggable id:[%s].", pluginConfiguration.getId())); } configuration.validateTree(); return (errors.isEmpty() && !configuration.hasErrors()); }
@Test public void hasErrorsShouldVerifyIfAnyConfigurationPropertyHasErrors() { ConfigurationProperty outputDirectory = mock(ConfigurationProperty.class); ConfigurationProperty inputDirectory = mock(ConfigurationProperty.class); when(outputDirectory.hasErrors()).thenReturn(false); when(inputDirectory.hasErrors()).thenReturn(true); Configuration configuration = new Configuration(outputDirectory, inputDirectory); assertTrue(configuration.hasErrors()); verify(outputDirectory).hasErrors(); verify(inputDirectory).hasErrors(); }
@Test public void isValidShouldVerifyForValidConfigurationProperties() { PluginConfiguration pluginConfiguration = new PluginConfiguration("github.pr", "1.1"); Configuration configuration = mock(Configuration.class); PluggableTaskConfigStore.store().setPreferenceFor(pluginConfiguration.getId(), mock(TaskPreference.class)); when(configuration.hasErrors()).thenReturn(true); PluggableTask pluggableTask = new PluggableTask(pluginConfiguration, configuration); assertFalse(pluggableTask.isValid()); verify(configuration).validateTree(); verify(configuration).hasErrors(); }
@Test public void validateTreeShouldVerifyIfConfigurationHasErrors() { Configuration configuration = mock(Configuration.class); PluggableTask pluggableTask = new PluggableTask(new PluginConfiguration(), configuration); when(configuration.hasErrors()).thenReturn(true); assertFalse(pluggableTask.validateTree(null)); }
@Test public void validate_shouldValidateFetchPluggableArtifactConfigurationUniqueness() { FetchPluggableArtifactTask task = new FetchPluggableArtifactTask(new CaseInsensitiveString("dummy"), new CaseInsensitiveString("stage"), new CaseInsensitiveString("job"), "s3", create("Foo", false, "Bar"), create("Foo", false, "Bar")); task.validate(ConfigSaveValidationContext.forChain(config, new TemplatesConfig(), downstream.getStage(new CaseInsensitiveString("stage")))); assertTrue(task.getConfiguration().hasErrors()); assertThat(task.getConfiguration().get(0).errors().on("configurationKey"), is("Duplicate key 'Foo' found for Fetch pluggable artifact")); assertThat(task.getConfiguration().get(1).errors().on("configurationKey"), is("Duplicate key 'Foo' found for Fetch pluggable artifact")); }