@Override public void visit(Field obj) { if (getFieldName().length() == 1) { return; } if (isEclipseNLS) { int flags = obj.getAccessFlags(); if ((flags & Const.ACC_STATIC) != 0 && ((flags & Const.ACC_PUBLIC) != 0) && "Ljava/lang/String;".equals(getFieldSig())) { // ignore "public statis String InstallIUCommandTooltip;" // messages from Eclipse NLS bundles return; } } if (badFieldName(obj)) { bugReporter.reportBug(new BugInstance(this, "NM_FIELD_NAMING_CONVENTION", classIsPublicOrProtected && (obj.isPublic() || obj.isProtected()) && !hasBadFieldNames ? NORMAL_PRIORITY : LOW_PRIORITY) .addClass(this).addVisitedField(this)); } }
@Override public void visitField(Field obj) { if (obj.isProtected()) { bugReporter.reportBug(new BugInstance(this, "CI_CONFUSED_INHERITANCE", LOW_PRIORITY).addClass(cls).addField( new FieldAnnotation(cls.getClassName(), obj.getName(), obj.getSignature(), obj.isStatic()))); } }
return; if (!aField.isPublic() && !aField.isProtected()) { return;
private List<FieldOrMethod> getMembers(JavaClass javaClass, List<JavaClass> interfaces) { Set<String> methodNames = new HashSet<>(); ArrayList<FieldOrMethod> members = new ArrayList<>(); List<Method> allInterfacesMethods = getAllInterfacesMethods(interfaces); List<Method> methods = new ArrayList<>(); methods.addAll(Arrays.asList(javaClass.getMethods())); methods.addAll(allInterfacesMethods); for (Method m : methods) { if ((m.isPublic() || m.isProtected()) && !m.isSynthetic()) { members.add(m); methodNames.add(m.getName()); } } for (Field f : javaClass.getFields()) { if ((f.isPublic() || f.isProtected()) && !f.isSynthetic() && !methodNames.contains(f.getName())) { members.add(f); } } return members; }
@Override public void visit(Field obj) { if (getFieldName().length() == 1) { return; } if (isEclipseNLS) { int flags = obj.getAccessFlags(); if ((flags & ACC_STATIC) != 0 && ((flags & ACC_PUBLIC) != 0) && "Ljava/lang/String;".equals(getFieldSig())) { // ignore "public statis String InstallIUCommandTooltip;" // messages from Eclipse NLS bundles return; } } if (badFieldName(obj)) { bugReporter.reportBug(new BugInstance(this, "NM_FIELD_NAMING_CONVENTION", classIsPublicOrProtected && (obj.isPublic() || obj.isProtected()) && !hasBadFieldNames ? NORMAL_PRIORITY : LOW_PRIORITY) .addClass(this).addVisitedField(this)); } }
@Override public void visitField(Field obj) { if (obj.isProtected()) { bugReporter.reportBug(new BugInstance(this, "CI_CONFUSED_INHERITANCE", LOW_PRIORITY).addClass(cls).addField( new FieldAnnotation(cls.getClassName(), obj.getName(), obj.getSignature(), obj.isStatic()))); } }
return; if (!aField.isPublic() && !aField.isProtected()) { return;
int maxone=0; if (obj.isPrivate()) maxone++; if (obj.isProtected()) maxone++; if (obj.isPublic()) maxone++; if (maxone > 1){
maxone++; if (obj.isProtected()) { maxone++;
if (f.isProtected()){ ObjectType classtype = o.getClassType(cpg); ObjectType curr = new ObjectType(mg.getClassName());
if (f.isProtected()) { final ObjectType classtype = getObjectType(o); final ObjectType curr = ObjectType.getInstance(mg.getClassName());
if (f.isProtected()){ ObjectType classtype = o.getClassType(cpg); ObjectType curr = new ObjectType(mg.getClassName());
if (f.isProtected()) { final ObjectType classtype = getObjectType(o); final ObjectType curr = ObjectType.getInstance(mg.getClassName());